Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Offload] Fixes typo in aarch64 triple #91622

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

tuliom
Copy link
Contributor

@tuliom tuliom commented May 9, 2024

Use llvm::Triple:aarch64 as the little-endian triple.

Fixes commit 3e54768.

Use llvm::Triple:aarch64 as the little-endian triple.

Fixes commit 3e54768.
@tuliom tuliom requested a review from jhuber6 May 9, 2024 16:44
@llvmbot llvmbot added the offload label May 9, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented May 9, 2024

@llvm/pr-subscribers-offload

Author: Tulio Magno Quites Machado Filho (tuliom)

Changes

Use llvm::Triple:aarch64 as the little-endian triple.

Fixes commit 3e54768.


Full diff: https://github.com/llvm/llvm-project/pull/91622.diff

1 Files Affected:

  • (modified) offload/plugins-nextgen/host/src/rtl.cpp (+1-1)
diff --git a/offload/plugins-nextgen/host/src/rtl.cpp b/offload/plugins-nextgen/host/src/rtl.cpp
index 4bdcae3dd6a1b..c6acad498e880 100644
--- a/offload/plugins-nextgen/host/src/rtl.cpp
+++ b/offload/plugins-nextgen/host/src/rtl.cpp
@@ -431,7 +431,7 @@ struct GenELF64PluginTy final : public GenericPluginTy {
     return llvm::Triple::systemz;
 #elif defined(__aarch64__)
 #ifdef LITTLEENDIAN_CPU
-    return llvm::Triple::aarch64_le;
+    return llvm::Triple::aarch64;
 #else
     return llvm::Triple::aarch64_be;
 #endif

@tuliom
Copy link
Contributor Author

tuliom commented May 9, 2024

@jhuber6 Could you take a look at this, please?
It fixes a typo from #91283.

@tuliom
Copy link
Contributor Author

tuliom commented May 9, 2024

By the way, it fixes this error:

May 09 05:24:16 /builddir/build/BUILD/llvm-project-19.0.0.src/offload/plugins-nextgen/host/src/rtl.cpp:436:26: error: no member named 'aarch64_le' in 'llvm::Triple'; did you mean 'aarch64_be'?
May 09 05:24:16   436 |     return llvm::Triple::aarch64_le;
May 09 05:24:16       |            ~~~~~~~~~~~~~~^~~~~~~~~~
May 09 05:24:16       |                          aarch64_be
May 09 05:24:16 /builddir/build/BUILD/llvm-project-19.0.0.src/llvm/include/llvm/TargetParser/Triple.h:52:5: note: 'aarch64_be' declared here
May 09 05:24:16    52 |     aarch64_be,     // AArch64 (big endian): aarch64_be
May 09 05:24:16       |     ^
May 09 05:24:16 1 error generated.

The full log is available at: https://download.copr.fedorainfracloud.org/results/@fedora-llvm-team/llvm-snapshots-big-merge-20240509/fedora-rawhide-aarch64/07428061-llvm/builder-live.log.gz

@jhuber6 jhuber6 merged commit e9be129 into llvm:main May 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants