Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/18.x: [X86][Driver] Do not add -evex512 for -march=native when the target doesn't support AVX512 (#91694) #91705

Merged
merged 1 commit into from
May 14, 2024

Conversation

llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented May 10, 2024

Backport 87f3407

Requested by: @phoebewang

@llvmbot llvmbot added this to the LLVM 18.X Release milestone May 10, 2024
@llvmbot
Copy link
Collaborator Author

llvmbot commented May 10, 2024

@topperc What do you think about merging this PR to the release branch?

@thesamesam
Copy link
Member

thesamesam commented May 14, 2024

@tstellar We've had a load of reports from the issue this fixes breaking compiles on machines without AVX512 for e.g. LibreOffice, Chromium. Could this be included in .6 please?

(Introduced by a7b8b89 on the branch.)

EDIT: Ah, I see you've noticed already at #91694 (comment).

@thesamesam thesamesam requested a review from tstellar May 14, 2024 02:15
@phoebewang
Copy link
Contributor

This patch fixes build failures when compiling AVX512 code using -march=native on machines without AVX512. The problem was introduced by a7b8b89 which is included in LLVM 18.1.5 release.

Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…et doesn't support AVX512 (llvm#91694)

(cherry picked from commit 87f3407)
@tstellar tstellar merged commit fac122a into llvm:release/18.x May 14, 2024
9 of 10 checks passed
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request May 16, 2024
Bug: llvm/llvm-project#91705
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants