Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc] add errno_macro header to bazel build #92044

Merged
merged 1 commit into from
May 13, 2024

Conversation

michaelrj-google
Copy link
Contributor

Patch #91150 added a proxy header for errno macros. This patch fixes the
bazel build since it needs to be added as a dependency.

Patch llvm#91150 added a proxy header for errno macros. This patch fixes the
bazel build since it needs to be added as a dependency.
@llvmbot llvmbot added libc bazel "Peripheral" support tier build system: utils/bazel labels May 13, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented May 13, 2024

@llvm/pr-subscribers-libc

Author: Michael Jones (michaelrj-google)

Changes

Patch #91150 added a proxy header for errno macros. This patch fixes the
bazel build since it needs to be added as a dependency.


Full diff: https://github.com/llvm/llvm-project/pull/92044.diff

1 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/BUILD.bazel (+6)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 6255ac998db10..ce61c432c2ed2 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -117,6 +117,11 @@ libc_support_library(
     hdrs = ["hdr/sys_epoll_macros.h"],
 )
 
+libc_support_library(
+    name = "hdr_errno_macros",
+    hdrs = ["hdr/errno_macros.h"],
+)
+
 ############################ Type Proxy Header Files ###########################
 
 libc_support_library(
@@ -1144,6 +1149,7 @@ libc_function(
         ":__support_common",
         ":__support_macros_attributes",
         ":__support_macros_properties_architectures",
+        ":hdr_errno_macros",
     ],
 )
 

@michaelrj-google michaelrj-google merged commit 4c79d38 into llvm:main May 13, 2024
7 checks passed
@michaelrj-google michaelrj-google deleted the libcErrnoBazelFix branch May 13, 2024 23:05
nhasabni pushed a commit to nhasabni/llvm-project that referenced this pull request May 14, 2024
Patch llvm#91150 added a proxy header for errno macros. This patch fixes the
bazel build since it needs to be added as a dependency.
@robincaloudis
Copy link
Contributor

Thank you for backing me up so quickly!

mub-at-arm pushed a commit to mub-at-arm/llvm-project that referenced this pull request May 16, 2024
Patch llvm#91150 added a proxy header for errno macros. This patch fixes the
bazel build since it needs to be added as a dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel libc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants