Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang][OpenMP] Add -fopenmp-version=52 to teams.f90 #92180

Merged
merged 1 commit into from
May 15, 2024

Conversation

kparzysz
Copy link
Contributor

One of the functions in the test has teams if(...). The if clause was only allowed on the teams directive in OpenMP 5.2.

One of the functions in the test has `teams if(...)`. The `if` clause
was only allowed on the `teams` directive in OpenMP 5.2.
@llvmbot
Copy link
Collaborator

llvmbot commented May 14, 2024

@llvm/pr-subscribers-flang-openmp

@llvm/pr-subscribers-flang-fir-hlfir

Author: Krzysztof Parzyszek (kparzysz)

Changes

One of the functions in the test has teams if(...). The if clause was only allowed on the teams directive in OpenMP 5.2.


Full diff: https://github.com/llvm/llvm-project/pull/92180.diff

1 Files Affected:

  • (modified) flang/test/Lower/OpenMP/teams.f90 (+1-1)
diff --git a/flang/test/Lower/OpenMP/teams.f90 b/flang/test/Lower/OpenMP/teams.f90
index f122a578a6e16..b1b2e7080676e 100644
--- a/flang/test/Lower/OpenMP/teams.f90
+++ b/flang/test/Lower/OpenMP/teams.f90
@@ -1,6 +1,6 @@
 ! REQUIRES: openmp_runtime
 
-! RUN: %flang_fc1 -emit-hlfir -fopenmp %s -o - | FileCheck %s
+! RUN: %flang_fc1 -emit-hlfir -fopenmp -fopenmp-version=52 %s -o - | FileCheck %s
 
 ! CHECK-LABEL: func @_QPteams_simple
 subroutine teams_simple()

Copy link
Contributor

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

The list of directives in the if clause and the list of clauses in teams do not seem to mention this. But i can see it in the Semantics section of teams.

Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

flang/test/Lower/OpenMP/teams.f90 Show resolved Hide resolved
@kparzysz kparzysz merged commit e6ef836 into llvm:main May 15, 2024
8 checks passed
@kparzysz kparzysz deleted the users/kparzysz/teams-assertion branch May 15, 2024 11:46
mub-at-arm pushed a commit to mub-at-arm/llvm-project that referenced this pull request May 16, 2024
One of the functions in the test has `teams if(...)`. The `if` clause
was only allowed on the `teams` directive in OpenMP 5.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:fir-hlfir flang:openmp flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants