[reland][flang] Add ETIME runtime and lowering intrinsics implementation #92571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This adds |
No, it was a mistake to add 'etime-function.mlir' to the top-level directory. I will correct this. Thank you for pointing it out. |
JumpMasterJJ
added a commit
that referenced
this pull request
May 18, 2024
The purpose of this PR is to remove the 'etime-function.mlir' file that I mistakenly committed in #92571. This file is not necessary in source code control, and its presence may cause confusion or misunderstanding.
luporl
added a commit
to luporl/llvm-project
that referenced
this pull request
Jun 4, 2024
flang/runtime/time-intrinsic.cpp:403:19: error: comparison of
integers of different signs: 'clock_t' (aka 'unsigned long') and
'int' [-Werror,-Wsign-compare]
if (times(&tms) != -1) {
luporl
added a commit
that referenced
this pull request
Jun 5, 2024
vedantparanjape-amd
pushed a commit
to vedantparanjape-amd/llvm-project
that referenced
this pull request
Jun 7, 2024
flang/runtime/time-intrinsic.cpp:403:19: error: comparison of
integers of different signs: 'clock_t' (aka 'unsigned long') and
'int' [-Werror,-Wsign-compare]
if (times(&tms) != -1) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is same as #90578 with an added fix. This PR updated tests of etime intrinsic due to Lowering changes for assigning dummy_scope to hlfir.declare. Referring to #92472 and #90989