Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lldb] Unify Platform::ResolveExecutable #96256

Merged
merged 2 commits into from
Jun 21, 2024
Merged

[lldb] Unify Platform::ResolveExecutable #96256

merged 2 commits into from
Jun 21, 2024
+15 −348

Commits on Jun 21, 2024

  1. [lldb] Unify Platform::ResolveExecutable duplication 

    The Platform class currently has two functions to resolve an executable:
`ResolveExecutable` and `ResolveRemoteExecutable`. The former strictly
deals with local files while the latter can handle potentially remote
files. I couldn't figure out why the distinction matters, at the latter
is a super-set of the former.

To make things even more confusion, we had a similar but not identical
implementation in RemoteAwarePlatform where its implementation of
`ResolveExecutable` could handle remote files. To top it all off, we had
copy-pasted implementation, dead code included in
`PlatformAppleSimulator` and `PlatformRemoteDarwinDevice`.

I went ahead and unified all the different implementation on the
original `ResolveRemoteExecutable` implementation. As far as I can tell,
it should work for every other platform, and the test suite (on macOS)
seems to agree with me, except for a small wording change.
    @JDevlieghere
    JDevlieghere committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    41f7b78 View commit details
    Browse the repository at this point in the history

  2. Remove stray comment

    @JDevlieghere
    JDevlieghere committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a10fe0f View commit details
    Browse the repository at this point in the history