[SandboxIR] Add setOperand() and RAUW,RUWIf,RUOW #98410
Merged
+176
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschuett
reviewed
Jul 11, 2024
| @@ -303,6 +309,13 @@ class Value { | |||
| #endif | |||
| }; | |||
|
|
|||
| /// Helper Attorney-Client class that gives access to the underlying IR. | |||
There was a problem hiding this comment.
Could the ValueAttorney be in the cpp file? It is kind of a public loop hole.
There was a problem hiding this comment.
It will only give access to the LLVM Value to its friends, so I don't see how it is a loop hole.
There was a problem hiding this comment.
can we add friend class User; in Value instead?
There was a problem hiding this comment.
Yes we can, and in this case it makes sense to use a friend because the User class is expected to be tightly coupled to the Value class. But for classes that are not as closely related to the IR, like the transaction tracker, it is nicer to use a client-attorney class to restrict access to just the LLVM Value and nothing else. Anyway, I will remove it for now and add it in later.
aeubanks
reviewed
Jul 11, 2024
| @@ -303,6 +309,13 @@ class Value { | |||
| #endif | |||
| }; | |||
|
|
|||
| /// Helper Attorney-Client class that gives access to the underlying IR. | |||
There was a problem hiding this comment.
can we add friend class User; in Value instead?
This patch adds the following member functions: - User::setOperand() - User::replaceUsesOfWith() - Value::replaceAllUsesWith() - Value::replaceUsesWithIf()
aeubanks
approved these changes
Jul 11, 2024
echristo
reviewed
Jul 11, 2024
There was a problem hiding this comment.
I think I'd like to see the comments expanded in SandboxIR in general to talk about what aspects you need to handle specifically before delegating down to LLVM IR. Right now it's a little hard to tell what is part of the layer on top of LLVM IR and what's just a delegate.
As an example: the asserts in rauw are the same as in the delegate .
|
Ah yes, we have not added any of the transaction tracking code yet, so the IR will currently delegate everything down to LLVM IR. Once we add the tracking code all these functions that modify the IR's state, like RAUW, setOperand, moveBefore etc. will include code that tracks the state change. The first patches that will add some of this functionality are a couple of patches down the road. |
|
That makes sense. A next patch to add the "delegate for X work" comments
might be good just to make sure that the code is straightforward for
reviews. Thoughts?
…On Thu, Jul 11, 2024 at 2:15 PM vporpo ***@***.***> wrote:
Ah yes, we have not added any of the transaction tracking code yet, so the
IR will currently delegate everything down to LLVM IR. Once we add the
tracking code all these functions that modify the IR's state, like RAUW,
setOperand, moveBefore etc. will include code that tracks the state change.
The first patches that will add some of this functionality are a couple of
patches down the road.
—
Reply to this email directly, view it on GitHub
<#98410 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACP5DBBSM2MVBY4JYDZGVDZL3YVXAVCNFSM6AAAAABKV2YLJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRTHE2TCNBRGA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
OK I will update this patch with some comments and I will follow up with another one that adds these comments to the remaining functions. The assumption is that all SandboxIR functions with the same name as the corresponding LLVM IR function is almost always a delegate, but yeah clarifying that is always helpful. |
|
I will upload the additional comments in a separate patch. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/1401 Here is the relevant piece of the build log for the reference: |
aaryanshukla
pushed a commit
to aaryanshukla/llvm-project
that referenced
this pull request
Jul 14, 2024
This patch adds the following member functions: - User::setOperand() - User::replaceUsesOfWith() - Value::replaceAllUsesWith() - Value::replaceUsesWithIf()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the following member functions: