Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lld][ELF] Error when deplibs adds new input file after LTO #98565

Merged
merged 3 commits into from
Jul 12, 2024
Merged

[lld][ELF] Error when deplibs adds new input file after LTO #98565

merged 3 commits into from
Jul 12, 2024
+52 −0

Commits on Jul 12, 2024

  1. [lld][ELF] Error when deplibs adds new input file after LTO 

    Parsing the new input file's symbols might invalidate LTO codegen, but
the semantics of deplibs require them to be parsed. Accordingly, report
an error unless the file had already been added to the link.

Fixes llvm#56070
    @mysterymath
    mysterymath committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    a750de6 View commit details
    Browse the repository at this point in the history

  2. Quick update: 

     - Consistent plurality in comment
 - errorOrWarn, since an output file may still producible
    @mysterymath
    mysterymath committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c6fc309 View commit details
    Browse the repository at this point in the history

  3. Address review feedback: 

    - Require aarch64
- Fix typo
- Remove blank lines in test
- Include reason for illegality in comment

Misc:

- Remove backticks around file and section names
    @mysterymath
    mysterymath committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    3c08523 View commit details
    Browse the repository at this point in the history