Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flang] Re-land PR#97337 #98656

Merged
merged 2 commits into from
Jul 12, 2024
Merged

[flang] Re-land PR#97337 #98656

merged 2 commits into from
Jul 12, 2024
+17 −9

Commits on Jul 12, 2024

  1. [flang] Adjust semantics of the char length of an array constructor 

    An implied DO loop with no trips in an array constructor does not have
a well-defined character length unless its data items have a length that
is constant expression.  That works, but the implementation is too broadly
applied.  An array constructor with an explicit type-spec always has a
well-defined length.
    @klausler
    klausler committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9f1cfe0 View commit details
    Browse the repository at this point in the history

  2. [flang] Re-land PR#97337 

    Pull request llvm#97337 was
reverted by llvm#98612 due
to two failing tests in llvm-test-suite -- which I ran, as always,
but must have bungled or misinterpreted (mea culpa).

The failing tests were llvm-test-suite/Fortran/gfortran/regression/
char_length_{20,21}.f90.  They have array constructors with
explicit character types whose dynamic length values are negative
at runtime and which must be interpreted as zero.

This patch extends the original to cover those cases.
    @klausler
    klausler committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    82cea79 View commit details
    Browse the repository at this point in the history