Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc] newheadergen: created sys folder for yaml files, make appropriate updates to CMake file for sys folder #98693

Merged
merged 3 commits into from
Jul 12, 2024
Merged

[libc] newheadergen: created sys folder for yaml files, make appropriate updates to CMake file for sys folder #98693

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc53565
[libc] newheadergen: created sys folder for yaml files, make appropri…
RoseZhang03 Jul 12, 2024
bf4d973
added comment
RoseZhang03 Jul 12, 2024
9026b83
deleted comments, will fix header file generation filepath in next patch
RoseZhang03 Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions libc/newhdrgen/yaml/sys_auxv.yaml → libc/newhdrgen/yaml/sys/sys_auxv.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
header: sys-auxv.h
standards:
- GNUExtensions
macros: []
types: []
enums: []
Expand Down
0 libc/newhdrgen/yaml/sys_epoll.yaml → libc/newhdrgen/yaml/sys/sys_epoll.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_ioctl.yaml → libc/newhdrgen/yaml/sys/sys_ioctl.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_mman.yaml → libc/newhdrgen/yaml/sys/sys_mman.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_prctl.yaml → libc/newhdrgen/yaml/sys/sys_prctl.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_random.yaml → libc/newhdrgen/yaml/sys/sys_random.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_resource.yaml → libc/newhdrgen/yaml/sys/sys_resource.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_select.yaml → libc/newhdrgen/yaml/sys/sys_select.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_sendfile.yaml → libc/newhdrgen/yaml/sys/sys_sendfile.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_socket.yaml → libc/newhdrgen/yaml/sys/sys_socket.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_stat.yaml → libc/newhdrgen/yaml/sys/sys_stat.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_statvfs.yaml → libc/newhdrgen/yaml/sys/sys_statvfs.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_syscall.yaml → libc/newhdrgen/yaml/sys/sys_syscall.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_time.yaml → libc/newhdrgen/yaml/sys/sys_time.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_types.yaml → libc/newhdrgen/yaml/sys/sys_types.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_utsname.yaml → libc/newhdrgen/yaml/sys/sys_utsname.yaml
View file
Open in desktop
File renamed without changes.
0 libc/newhdrgen/yaml/sys_wait.yaml → libc/newhdrgen/yaml/sys/sys_wait.yaml
View file
Open in desktop
File renamed without changes.
9 changes: 9 additions & 0 deletions libc/newhdrgen/yaml_to_classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,15 @@ def main(yaml_file, h_def_file, output_dir, add_function=None):
output_file_name = Path(h_def_file).stem
output_file_path = Path(output_dir) / output_file_name

# with open(yaml_file, "r") as f:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to leave this in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a placeholder for now while I wait for the CMake to come out. I'm not sure if I can manually add sys to the file path here or if I will have to make an alternate path in the CMake file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case I'd say it's probably best to leave this out of this patch. Commented out code is often confusing when reading a file

# yaml_data = yaml.safe_load(f)

# header_name = yaml_data[header]
# if len(header_name) >= 6 and header_name[0:4] == "sys-":
# output_file_path = Path(output_dir) / sys / output_file_name
# or maybe:
# output_file_path = Path(other_output_dir) / output_file_name

with open(output_file_path, "w") as f:
f.write(final_header_content)

Expand Down
Loading