[Fortran] Comment out tests with missing semantic checks #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are looking for a semantic error that flang is not emitting but they used to pass because a TODO for procedure pointers was emitted in lowering. Lowering implemented procedure pointers, so these test now fail. I opened an issue against semantics, but I want to comment out these tests so that we can still land the lowering implementation of procedure pointers that is correct. See llvm/llvm-project#73215
jeanPerier
requested review from
tblah,
kiranchandramohan,
tarunprabhu and
DanielCChen
tarunprabhu
pushed a commit
to llvm-project-tlp/llvm-test-suite
that referenced
this pull request
Dec 8, 2023
These tests are looking for a semantic error that flang is not emitting but they used to pass because a TODO for procedure pointers was emitted in lowering. Lowering implemented procedure pointers, so these test now fail. I opened an issue against semantics, but I want to comment out these tests so that we can still land the lowering implementation of procedure pointers that is correct. See llvm/llvm-project#73215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are looking for a semantic error that flang is not emitting but they used to pass because a TODO for procedure pointers was emitted in lowering. Lowering implemented procedure pointers, so these test now fail. I opened an issue against semantics, but I want to comment out these tests so that we can still land the lowering implementation of procedure pointers that is correct (the lowering change was reverted for now).
See llvm/llvm-project#73215