Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Add OnnxToTorch lowering for Onnx.Upsample Op #3371

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

vivekkhandelwal1
Copy link
Collaborator

Signed-Off By: Vivek Khandelwal vivekkhandelwal1424@gmail.com

Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions and nits.

I'd like to hear about the e2e tests, and would like to request some comments to be included to make it easier for others to contribute more functionality in the future.

lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp Outdated Show resolved Hide resolved
lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp Outdated Show resolved Hide resolved
test/Conversion/TorchOnnxToTorch/simple_ops_q_to_z.mlir Outdated Show resolved Hide resolved
lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp Outdated Show resolved Hide resolved
@vivekkhandelwal1
Copy link
Collaborator Author

Hi @zjgarvey, the PR is updated, can you please review it now?

Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change related to the mode string should be made.

lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp Outdated Show resolved Hide resolved
@vivekkhandelwal1
Copy link
Collaborator Author

Hi @zjgarvey, I have addressed the comment. Could you please take a look now?

@vivekkhandelwal1 vivekkhandelwal1 merged commit 3c3fbe4 into llvm:main Jun 25, 2024
3 checks passed
@vivekkhandelwal1 vivekkhandelwal1 deleted the onnx-upsample branch June 25, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants