-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Add OnnxToTorch lowering for Onnx.Upsample Op #3371
Conversation
b132ae3
to
06c71f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions and nits.
I'd like to hear about the e2e tests, and would like to request some comments to be included to make it easier for others to contribute more functionality in the future.
06c71f7
to
192d59a
Compare
Hi @zjgarvey, the PR is updated, can you please review it now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small change related to the mode string should be made.
Signed-Off By: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
192d59a
to
9100b14
Compare
Hi @zjgarvey, I have addressed the comment. Could you please take a look now? |
Signed-Off By: Vivek Khandelwal vivekkhandelwal1424@gmail.com