Fix Llama2 formatting #1997
Merged
Fix Llama2 formatting #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ruanslv thanks, looking into it, just one question about the double spaces |
infwinston
requested changes
Jul 18, 2023
| @@ -847,17 +847,17 @@ def get_conv_template(name: str) -> Conversation: | |||
| register_conv_template( | |||
| Conversation( | |||
| name="llama-2", | |||
| system="<s>[INST] <<SYS>>\nYou are a helpful, respectful and honest assistant. Always answer as helpfully as possible, while being safe. " | |||
| system="<s>[INST] <<SYS>>\nYou are a helpful, respectful and honest assistant. Always answer as helpfully as possible, while being safe. " | |||
There was a problem hiding this comment.
there are two spaces right? according to
https://github.com/facebookresearch/llama/blob/cfc3fc8c1968d390eb830e65c63865e980873a06/llama/generation.py#L47
There was a problem hiding this comment.
or is that a typo in llama repo?
infwinston
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
I'm assuming the double space in the official llama repo is typo given you are the author. I'll merge this now. Thanks a lot for fixing the format! @ruanslv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following: https://github.com/facebookresearch/llama/blob/cfc3fc8c1968d390eb830e65c63865e980873a06/llama/generation.py#L212