Intel ARC/XPU Improvements #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't test this without multiple GPUs, but it doesn't break anything for one GPU.
Turns out this does actually speed things up.
merrymercy
requested changes
Jul 23, 2023
merrymercy
reviewed
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
--gpusarg should work to select between multiple Intel GPUs now (but I only have one so I can't really test it).import touchup a few lines fixed it).Also, for a while float16 was broken on Intel but it seems fixed now, I was wondering should I use float16 so it's consistent with cuda and metal or just stick with bfloat16?
Related issue number (if applicable)
N/A
Checks
format.shto lint the changes in this PR.