Add WizardCoder model support #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
requested changes
Aug 8, 2023
fastchat/conversation.py
Outdated
| @@ -896,6 +896,19 @@ def get_conv_template(name: str) -> Conversation: | |||
| ) | |||
| ) | |||
|
|
|||
| # WizardCoder default template, same as alpaca | |||
There was a problem hiding this comment.
- Could you put a link to the source here?
- If it is the same as alpaca, we may not need to create a new template for it, we can just return "alpaca" in
model_adapter.py
There was a problem hiding this comment.
Thank you for your feedback, I have changed the implementation to return the alpaca template directly from the ModelAdapter, without having to register a new conversation template and add the link in comment. Does it ok for you? Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add the support of WizardCoder model which is a model specialized into code generation through chat.
Related issue number (if applicable)
NA
Checks
format.shto lint the changes in this PR.