update baichuan chat template #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
reviewed
Aug 8, 2023
fastchat/conversation.py
Outdated
| sep="", | ||
| sep2="</s>", | ||
| stop_token_ids=[2, 195], | ||
| sep2="", |
There was a problem hiding this comment.
sep2 should not be deleted because it is used in vllm
https://github.com/vllm-project/vllm/blob/79af7e96a0e2fc9f340d1939192122c3ae38ff17/vllm/entrypoints/openai/api_server.py#L92
merrymercy
reviewed
Aug 8, 2023
merrymercy
reviewed
Aug 8, 2023
| stop_token_ids=[2, 195], | ||
| stop_token_ids=[], |
There was a problem hiding this comment.
Could you clarify why the stop token IDs are being deleted? Are they no longer required?
Did you test the CLI and check whether the model can stop successfully?
There was a problem hiding this comment.
I tested the submitted code in vllm and everything is fine and the inference results are as expected
vllm uses fschat
merrymercy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Update baichuan-13b-chat tokenizer rules
Related issue number (if applicable)
#2175
Checks
format.shto lint the changes in this PR.