Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Update the warning to follow the new conv_template file #2248

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

persistz
Copy link
Contributor

Why are these changes needed?

In the commit #1008 , fastchat updated the model and conversation template, but ignored to sync the warning message in the model_adapter.py, which will cause a template cannot find error if user follows the command in the warning.

Related issue number (if applicable)

In several closed issues (#408 #422 ), the authors of fastchat quoted this warning message, this warning should be updated synchronously with the conv template.

Checks

  • I've run format.sh to lint the changes in this PR.
  • I've included any doc changes needed.
  • I've made sure the relevant tests are passing (if applicable).

As this is only an updating of warning message, I think there is no related tests and docs to check here.

@persistz persistz changed the title Update the warning to follow the new conv_template file [Minor] Update the warning to follow the new conv_template file Aug 17, 2023
@merrymercy merrymercy merged commit d294434 into lm-sys:main Aug 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants