Store Images Remotely on GCS #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Ying1123
approved these changes
Apr 14, 2024
| @@ -527,7 +556,7 @@ def bot_response( | |||
| "finish": round(finish_tstamp, 4), | |||
| "state": state.dict(), | |||
| "ip": get_ip(request), | |||
| "images": images_hash, | |||
| "images": image_filenames, | |||
There was a problem hiding this comment.
Should it be put into the conversation logic as well?
There was a problem hiding this comment.
Nice catch! I think this was written under the original assumption that the image hashes are not stored in the state.dict() which is a new feature added in #3010. I think a good idea may be to first merge this PR then in #3010, I can fix the merge conflicts by placing the image filenames in the state.dict() similar to the code here.
There was a problem hiding this comment.
Sounds good. I'll merge this one.
renning22
added a commit
to renning22/FastChat
that referenced
this pull request
Apr 22, 2024
Fix missing flag introduced in lm-sys#3172
adamlin120
pushed a commit
to adamlin120/FastChat
that referenced
this pull request
May 13, 2024
* original_lmsys/operation: (70 commits) format update update update format update update update Small fix in clean_chat_data (lm-sys#3285) support llama3 (lm-sys#3259) Fix bug in gradio_web_server.py (lm-sys#3269) Register SmaugChatAdapter. (lm-sys#3243) update Code update (lm-sys#3194) Store Images Remotely on GCS (lm-sys#3172) format remove format update Add support for Smaug-2. (lm-sys#3211) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds ability to store images onto GCS.
Checks
format.shto lint the changes in this PR.