Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
y2038: linux: Provide __clock_settime64 implementation
This patch provides new __clock_settime64 explicit 64 bit function for setting the time. Moreover, a 32 bit version - __clock_settime - has been refactored to internally use __clock_settime64. The __clock_settime is now supposed to be used on systems still supporting 32 bit time (__TIMESIZE != 64) - hence the necessary conversion to 64 bit struct timespec. The new clock_settime64 syscall available from Linux 5.1+ has been used, when applicable. The __ASSUME_TIME64_SYSCALLS flag indicates if the Linux kernel supports 64 bit version of clock_settime (i.e. clock_settime64). If this flag is not defined, the fallback with legacy clock_settime supporting 32 bit time is used. When working on 32 bit systems without Y2038 time support the clock_settime64 returns error when one wants to set time with wrong (overflowed) tv_sec value. Moreover, the correctness of tv_nsec is also checked. In this patch the internal padding (tv_pad) of struct __timespec64 is left untouched (on systems with __WORDSIZE == 32) as Linux kernel ignores upper 32 bits of tv_nsec. Tests: - The code has been tested with x86_64/x86 (native compilation): make PARALLELMFLAGS="-j8" && make xcheck PARALLELMFLAGS="-j8" - Run specific tests on ARM/x86 32bit systems (qemu): https://github.com/lmajewski/meta-y2038 and run tests: https://github.com/lmajewski/y2038-tests/commits/master on kernels with and without 64 bit time support. No regressions were observed. * include/time.h (__clock_settime64): Add __clock_settime alias according to __TIMESIZE define * sysdeps/unix/sysv/linux/clock_settime.c (__clock_settime): Refactor this function to be used only on 32 bit machines as a wrapper on __clock_settime64. * sysdeps/unix/sysv/linux/clock_settime.c (__clock_settime64): Add * sysdeps/unix/sysv/linux/clock_settime.c (__clock_settime64): Use clock_settime64 kernel syscall (available from 5.1-rc1+ Linux) --- Changes for v5: - Use __ASSUME_TIME64_SYSCALLS to indicate Linux kernel support for 64 bit time. - Move the in_time_t_range() check to __clock_settime64 - Alias __NR_clock_settime64 to __NR_clock_settime if the former is not defined in the headers. Changes for v4: - __ASSUME_TIME64_SYSCALLS for fall back path - Use __SYSCALL_WORDSIZE to exclude 'x32' from execution path (so it will use x86_64 syscall - Rewrite the commit message Changes for v3: - Rename __ASSUME_64BIT_TIME to __ASSUME_TIME64_SYSCALLS - Refactor in-code comment (add information regarding Linux kernel ignorance of padding - Do not use __TIMESIZE to select main execution path (for Y2038 systems __TIMESIZE would be changed from 32 to 64 bits at some point to indicate full Y2038 support Changes for v2: - Add support for __ASSUME_64BIT_TIME flag when Linux kernel provides syscalls supporting 64 bit time on 32 bit systems - Provide fallback to 32 bit version of clock_settime when clock_settime64 is not available - Do not copy *tp to timespec - this seems like an overkill as in clock_settime() the 32 bit struct timespec is copied to internal 64 bit struct __timespec64
- Loading branch information