Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user as a fallback value for username #5

Merged
merged 3 commits into from
Apr 8, 2020
Merged

Add user as a fallback value for username #5

merged 3 commits into from
Apr 8, 2020

Conversation

hckhanh
Copy link
Contributor

@hckhanh hckhanh commented Apr 8, 2020 •
edited

Hi @lmammino,
For some cases, user refers to username. In other databases, user is referred.

@hckhanh
Update index.js
1bb0e38 
For some cases, `user` refers to `username`.
@coveralls
Copy link

coveralls commented Apr 8, 2020 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 8f1fa3b on hckhanh:patch-1 into 8ed5ded on lmammino:master.

@lmammino
Copy link
Owner

lmammino commented Apr 8, 2020

Thanks @hckhanh !

@lmammino lmammino merged commit d7eeb23 into lmammino:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hckhanh @coveralls @lmammino