feat: deny delete creation #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilteoood
force-pushed
the
chore/delay-deny-creation
branch
from
ce567dd
to
4429f15
Compare
lmammino
force-pushed
the
chore/delay-deny-creation
branch
from
4429f15
to
a1abaf7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 90.88% 90.87% -0.01%
==========================================
Files 9 9
Lines 922 921 -1
==========================================
- Hits 838 837 -1
Misses 84 84 ☔ View full report in Codecov by Sentry. |
|
Really good idea! Thanks for this awesome contribution @ilteoood <3 |
lmammino
force-pushed
the
chore/delay-deny-creation
branch
from
a1abaf7
to
954278e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Luciano,
since
denyis one of the last thing to be used before returning a response, with this PR I would like to delay its creation as long as we can in order to avoid always creating it for valid token.