Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vec to hashset #15

Merged
merged 2 commits into from
Apr 27, 2024
Merged

Conversation

ilteoood
Copy link
Contributor

Hi Luciano,
most of the operations you do with claims and algorithms are just contains.

I think that moving to an HashSet will make these operations faster.
Since you are building a benchmark for this project, it could be worth a try 😄

@lmammino lmammino force-pushed the chore/vec-to-hashset branch 2 times, most recently from d467333 to a4c44f9 Compare April 27, 2024 14:40
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.89%. Comparing base (efbac0c) to head (4b0955a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   90.87%   90.89%   +0.01%     
==========================================
  Files           9        9              
  Lines         921      923       +2     
==========================================
+ Hits          837      839       +2     
  Misses         84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmammino
Copy link
Owner

for small sets BTreeSets might be faster but until we have some microbenchmarks I think this is still an awesome improvements! :) thanks a lot

@lmammino lmammino merged commit 4670d45 into lmammino:main Apr 27, 2024
4 checks passed
@ilteoood ilteoood deleted the chore/vec-to-hashset branch April 27, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants