Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/enotfound with non standard port #12

Merged
merged 2 commits into from
Apr 23, 2019

Conversation

lmammino
Copy link
Owner

Fixes #11

@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #12 into master will decrease coverage by 5%.
The diff coverage is 93.75%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #12   +/-   ##
====================================
- Coverage     100%   95%   -5%     
====================================
  Files           1     1           
  Lines          15    20    +5     
  Branches        3     5    +2     
====================================
+ Hits           15    19    +4     
- Misses          0     1    +1
Impacted Files Coverage Δ
src/index.js 95% <93.75%> (-5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab43d98...b7cc452. Read the comment docs.

@lmammino
Copy link
Owner Author

Hello @alexdpoon can you please validate that these changes fix the issue you reported in #11 ?

Thanks :)

@lmammino lmammino merged commit 755f34f into master Apr 23, 2019
@lmammino lmammino deleted the fix/enotfound-with-non-standard-port branch April 23, 2019 12:19
@atomheartother atomheartother mentioned this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not throwing exception on "Error: getaddrinfo ENOTFOUND"
1 participant