Upgrade to npm@^9.0.0, drop Node.js 17 in favor of 19 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhorky
changed the title
karlhorky
changed the title
|
Hey @karlhorky, thanks for submitting this but it seems to be breaking our CI run... |
|
Yep, just moved from 17 to 19 to fix that... all green! ✅ |
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 52 52
Branches 9 9
=========================================
Hits 52 52 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks for the review + merge! |
|
Thanks for the PR, i'll release a new major shortly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @lmammino 👋 Hope you are well.
Since npm 9.0.0 was released, I thought it would make sense to upgrade to the newer version.
And because Node.js 17 is no longer supported, I dropped this in favor of Node.js 19.