Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations to estonian #94

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Translations to estonian #94

merged 7 commits into from
Apr 18, 2024

Conversation

Ottr-arch
Copy link
Contributor

Hi Luke, great project! Good instructions and easy to set up.
I added the estonian translations.
I found the AQI (EUROPE_CAQI) part confusing as "very low" is supposed to mean the quality is good :D. So I translated the "Air Quality Index" as just "Air Quality" in the oppopsite way from "very bad" to "very good" in estonian.

esp32-weather

@lmarzen
Copy link
Owner

lmarzen commented Apr 15, 2024

I found the AQI (EUROPE_CAQI) part confusing as "very low" is supposed to mean the quality is good :D. So I translated the "Air Quality Index" as just "Air Quality" in the oppopsite way from "very bad" to "very good" in estonian.

In regards to this, I think the confusion come from the fact that air quality scales try to answer one of two questions...

  1. How polluted is the air? (ex: European Union CAQI scale)
  2. How good is the air quality? (ex: United States AQI scale)

It is not always clear what question an AQI scale is trying to answer unless you refer to the governing documents.

Here is another issue on this project where a similar question is asked, #31. I have quoted part of my reply here for reference.

I used the Qualitative Name/Descriptor/Category outlined in the official standard for each AQI. Some AQI's attempt to fulfil different purposes, some present amount of air pollution like CAQI, and others like the US AQI present air quality closer to the sense that you are suggesting.

For the EU's CAQI...

from http://airqualitynow.eu/about_indices_definition.php
and
from http://www.airqualitynow.eu/download/CITEAIR-Comparing_Urban_Air_Quality_across_Borders.pdf

These indices have five levels using a scale from ‘0‘ (very low) to ‘> 100’ (very high). It presents a relative measure of the amount of air pollution.

For the US's AQI...

from https://www.airnow.gov/sites/default/files/2020-05/aqi-technical-assistance-document-sept2018.pdf

The purpose of the AQI is to inform people about their air quality so they can take steps to protect their health.

@Ottr-arch
Copy link
Contributor Author

Hi Luke. Thank you for the clarification. Yes, I found the same answers with my research because I also thought that it might be a bug, then I realized that it essentially represents the pollution level (why did they not name it like that? :D ) from low to high.
Which is why I renamed the field and removed the "Index" part to just say "Air quality" represented from "very bad" to "very good".
If you like, I can provide the correct translations and representation according to the correct CAQI format in Estonian and keep these current texts (which I find easier to understand) on my local build.

@lmarzen
Copy link
Owner

lmarzen commented Apr 16, 2024

You're right, this is definitely confusing as is. Maybe the label "Air Quality" needs to change depending on the scale selected. For EU CAQI the label should be "Pollution" or "Pollution Level". I'm going to add some code so the label used will depend on what AQI is selected. Then you can correct the translation.

@lmarzen
Copy link
Owner

lmarzen commented Apr 17, 2024

Based on your suggestion, I have reworked the code so that depending on the AQI scale being used, it will either say "Air Quality" or "Air Pollution.". I updated your pull request with the new fields so that it is compatible with the new changes to upstream. c7f01f5

You should be good to update the translations back to the true meanings and it should be more clear now.

@Ottr-arch
Copy link
Contributor Author

It was a good workaround 👍
Please look if all is good now, I'm new to git (neither am I a developer :D ) as this was my first pull request ever.

@lmarzen
Copy link
Owner

lmarzen commented Apr 18, 2024

Looks great! Give yourself a pat on the back for navigating it all like a pro, pretty impressive for a non-developer I would never have known :)

Thank you for your contribution.

@lmarzen lmarzen merged commit 052db99 into lmarzen:main Apr 18, 2024
3 checks passed
@Ottr-arch
Copy link
Contributor Author

The git part I was navigating with ChatGPT, which is impressive :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants