Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify file handling #241

Open
xrotwang opened this issue Aug 1, 2019 · 2 comments
Open

Unify file handling #241

xrotwang opened this issue Aug 1, 2019 · 2 comments
Assignees

Comments

@xrotwang
Copy link
Collaborator

xrotwang commented Aug 1, 2019

Now that we have py3.5 as baseline, we should unify all file handling to make use of pathlib. I.e. filenames should be handled like encoded strings: Convert to pathlib.Path as early as possible, and pass around pathlib.Path objects internally exclusively.

Also, reading and writing files can then be handled using the read_text and write_text method, etc.

@xrotwang xrotwang self-assigned this Aug 1, 2019
@Anaphory
Copy link
Collaborator

Anaphory commented Aug 1, 2019

Yes! You taught me to love pathlib.Path, this sounds like an excellent plan.

@xrotwang
Copy link
Collaborator Author

xrotwang commented Aug 1, 2019

@Anaphory and if you still love it, after the rough years of pathlib2 and backports for py2, you'll love it happily ever after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants