Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should base-clocks/models/priors be abstract? #255

Open
Anaphory opened this issue Jun 28, 2020 · 0 comments
Open

Should base-clocks/models/priors be abstract? #255

Anaphory opened this issue Jun 28, 2020 · 0 comments

Comments

@Anaphory
Copy link
Collaborator

BaseClock doesn't have a branch rate model, which to me makes that method pretty abstract, so the whole class is? It also lacks __type__ and __distribution__, and declaring it abstract would prevent an accidental instantiation if after some refactoring [clock] type=base would theoretically run etc.

Originally posted by @Anaphory in #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant