Skip to content

Commit

Permalink
CI: remove gotestsum postprocessing
Browse files Browse the repository at this point in the history
gotestsum can't properly process benchmark results due to a go toolchain
bug. Remove the postprocessing, since we don't benefit as much now that
we don't use Semaphore CI anymore (which had nice visualisation for
JUnit output).

See gotestyourself/gotestsum#332

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
  • Loading branch information
lmb committed Dec 1, 2023
1 parent 98affdd commit 6fa487b
Showing 1 changed file with 2 additions and 11 deletions.
13 changes: 2 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,11 @@ jobs:
with:
go-version: '${{ env.prev_go_version }}'

- run: go install gotest.tools/gotestsum@v1.8.1
- run: sudo pip3 install https://github.com/amluto/virtme/archive/beb85146cd91de37ae455eccb6ab67c393e6e290.zip
- run: sudo apt-get update && sudo apt-get install -y --no-install-recommends qemu-system-x86

- name: Test
run: gotestsum --raw-command --ignore-non-json-output-lines --junitfile junit.xml -- ./run-tests.sh $CI_MAX_KERNEL_VERSION -short -count 1 -bench . -benchtime=1x -json ./...
run: ./run-tests.sh $CI_MAX_KERNEL_VERSION -short -count 1 -bench . -benchtime=1x -v ./...

- name: Upload Test Results
if: always()
Expand All @@ -154,16 +153,8 @@ jobs:
with:
go-version: '${{ env.prev_go_version }}'

- run: go install gotest.tools/gotestsum@v1.8.1
- run: sudo pip3 install https://github.com/amluto/virtme/archive/beb85146cd91de37ae455eccb6ab67c393e6e290.zip
- run: sudo apt-get update && sudo apt-get install -y --no-install-recommends qemu-system-x86

- name: Test
run: gotestsum --raw-command --ignore-non-json-output-lines --junitfile junit.xml -- ./run-tests.sh $KERNEL_VERSION -short -count 1 -bench . -benchtime=1x -json ./...

- name: Upload Test Results
if: always()
uses: actions/upload-artifact@v3
with:
name: Test Results (${{ matrix.version }})
path: junit.xml
run: ./run-tests.sh $KERNEL_VERSION -short -count 1 -bench . -benchtime=1x -v ./...

0 comments on commit 6fa487b

Please sign in to comment.