Copy response in profilerItem not to store a reference to the original object #4
+54
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1065146349
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1065146349
💛 - Coveralls |
jirinovak
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because of an automatic object referencing - it is weird that your decoded response is cached in a different shape then it is shown in the profiler, which may occur if you change the object after it is returned from a
QueryFetcherbut it is not yet shown in the profiler (it would show the new updated version, not the one really decoded in the QueryFetcher and cached, if the Query is cacheable).