Skip to content

Commit

Permalink
Removed unused filter_type parameter.
Browse files Browse the repository at this point in the history
  • Loading branch information
JakubTesarek committed Aug 18, 2020
1 parent 6af2f7c commit 0447125
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -5,6 +5,8 @@
<!-- There is always Unreleased section on the top. Subsections (Added, Changed, Fixed, Removed) should be added as needed. -->

## Unreleased
### Changed
- Client doesn't send no longer used parameter `filter_type`.

## 3.0.0 - 2020-05-14
### Added
Expand Down
5 changes: 0 additions & 5 deletions src/Model/Command/UserRecommendation.php
Expand Up @@ -10,8 +10,6 @@
*/
class UserRecommendation extends AbstractCommand implements UserAwareInterface
{
public const FILTER_TYPE_MQL = 'mql';

/** @var string */
protected $filterOperator = 'and';
/** @var string */
Expand All @@ -30,8 +28,6 @@ class UserRecommendation extends AbstractCommand implements UserAwareInterface
private $minimalRelevance;
/** @var string[] */
private $filters;
/** @var string */
private $filterType = self::FILTER_TYPE_MQL;
/** @var string|null */
private $modelName;
/** @var string[] */
Expand Down Expand Up @@ -330,7 +326,6 @@ protected function getCommandParameters(): array

if ($this->filters !== null) {
$parameters['filter'] = $this->assembleFiltersString();
$parameters['filter_type'] = $this->filterType;
}

if ($this->responseProperties !== null) {
Expand Down
1 change: 0 additions & 1 deletion tests/unit/Model/Command/UserRecommendationTest.php
Expand Up @@ -64,7 +64,6 @@ public function shouldUseCustomParameters(): void
'hard_rotation' => true,
'min_relevance' => MinimalRelevance::HIGH,
'filter' => 'foo = bar and baz = ban',
'filter_type' => UserRecommendation::FILTER_TYPE_MQL,
'properties' => ['item_url'],
'model_name' => $modelName,
'allow_seen' => true,
Expand Down

0 comments on commit 0447125

Please sign in to comment.