Adapt to latest API changes #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eived, no matter their result (RAD-662)
OndraM
requested review from
kubasimon,
davidkmenta,
foglcz,
jirinovak,
kdosiodjinud,
MortalFlesh,
hokypierce,
MarketaSebkova and
florianjiri
kubasimon
approved these changes
Nov 16, 2017
davidkmenta
reviewed
Nov 16, 2017
| @@ -30,7 +30,7 @@ private function transformResponseToException(RequestInterface $request, Respons | |||
| throw AuthorizationException::fromRequestAndResponse($request, $response); | |||
| } | |||
|
|
|||
| if ($responseCode >= 401 && $responseCode < 600) { | |||
| if ($responseCode >= 400 && $responseCode < 600) { | |||
There was a problem hiding this comment.
Any reason why not use the StatusCodeInterface:: STATUS_BAD_REQUEST?
There was a problem hiding this comment.
IMHO it would actually lower the readability.
The condition is now explicitly read as "for all response codes between 400 and 600 do this".
Using the constant, it will look like:
"for all response codes between BAD_REQUEST and 600 do this". But this is not what the condition is intended for.
The constants IMO makes sense when comparing with specific response code, not with range of codes...
davidkmenta
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to changes from Matej release on Wednesday evening .
https://jira.int.lmc.cz/browse/RAD-663
https://jira.int.lmc.cz/browse/RAD-662