Send client version header #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndraM
requested review from
kubasimon,
davidkmenta,
foglcz,
jirinovak,
kdosiodjinud,
MortalFlesh,
hokypierce,
MarketaSebkova,
florianjiri and
a user
jirinovak
previously approved these changes
Nov 22, 2017
davidkmenta
previously approved these changes
Nov 22, 2017
ghost
reviewed
Nov 22, 2017
tests/Http/RequestManagerTest.php
Outdated
| @@ -53,5 +53,9 @@ public function shouldSendAndDecodeRequest(): void | |||
| $recordedRequests[0]->getBody()->__toString() | |||
| ); | |||
| $this->assertSame(['application/json'], $recordedRequests[0]->getHeader('Content-Type')); | |||
| $this->assertStringStartsWith( | |||
| 'php-client/', | |||
There was a problem hiding this comment.
Version will change every release. But ok, I can use the constant there, why not 🤷.
ghost
previously approved these changes
Nov 22, 2017
OndraM
force-pushed
the
feature/version-header
branch
from
e39004a
to
9c0cbed
Compare
OndraM
force-pushed
the
feature/version-header
branch
from
9c0cbed
to
72e6d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.