Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign request builder #39

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

OndraM
Copy link
Member

@OndraM OndraM commented Nov 27, 2017

Fixes #38.

Example usage:

$matej = new Matej('accountId', 'apikey');

$response = $matej->request()
    ->campaign()
    // Request item sortings
    ->addSorting(Sorting::create('user-id', ['item-id-1', 'item-id-2', 'item-id-3']))
    ->addSortings([/* array of Sorting objects */])
    // Request user-based recommendations
    ->addRecommendation(UserRecommendation::create('user-id', 10, 'emailing', 1.0, 3600))
    ->addRecommendations([/* array of UserRecommendation objects */])
    ->send();

@foglcz
Copy link
Contributor

foglcz commented Nov 27, 2017

Personally I'd add an integration test as well - can be done after merge of #40
(integration tests weren't available at the time of PR creation)

@OndraM OndraM force-pushed the feature/user-recommendation-command branch 2 times, most recently from c49b243 to bd7a0fb Compare November 27, 2017 15:59
@OndraM OndraM force-pushed the feature/campaign-request-builder branch from 01bef73 to 70f6b01 Compare November 27, 2017 16:08
@OndraM OndraM force-pushed the feature/campaign-request-builder branch from 70f6b01 to 1fa4158 Compare November 27, 2017 16:36
@OndraM OndraM changed the base branch from feature/user-recommendation-command to master November 27, 2017 16:36
@OndraM
Copy link
Member Author

OndraM commented Nov 27, 2017

Also we need to wait for RAD-719 with integration tests :)

@OndraM OndraM merged commit ad4f2f9 into lmc-eu:master Nov 27, 2017
@OndraM OndraM deleted the feature/campaign-request-builder branch January 15, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants