Response decoding #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndraM
requested review from
kubasimon,
davidkmenta,
foglcz,
jirinovak,
kdosiodjinud,
MortalFlesh,
hokypierce,
MarketaSebkova and
florianjiri
OndraM
force-pushed
the
feature/responses
branch
2 times, most recently
from
2a3dfba
to
1ea8d72
Compare
foglcz
approved these changes
Nov 15, 2017
mvondr
reviewed
Nov 15, 2017
| /** @var array */ | ||
| private $data = []; | ||
|
|
||
| private function __construct() |
There was a problem hiding this comment.
A private empty constructor means that this class cannot be instantiated.
davidkmenta
previously requested changes
Nov 15, 2017
| /** @var array */ | ||
| private $data = []; | ||
|
|
||
| private function __construct() |
There was a problem hiding this comment.
A private empty constructor means that this class cannot be instantiated.
src/Model/CommandResponse.php
Outdated
|
|
||
| public static function createFromRawCommandResponseObject(\stdClass $rawCommandResponseObject): self | ||
| { | ||
| $commandResponse = new self(); |
There was a problem hiding this comment.
This should be after the condition below
mvondr
approved these changes
Nov 15, 2017
OndraM
force-pushed
the
feature/responses
branch
from
ebd89a6
to
d53f3ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response JSON is decoded to
Responseobject, which then contains array ofCommandResponses- responses to individual commands which were send as part of request batch.The
Responsecould later maybe implement \Iterator, \ArrayAccess or maybe even \SplObjectStorage for simpler manipulation with the Command Responses. (see #8)Also note the compatibility layer for plain string command responses. It will be removed right after https://jira.int.lmc.cz/browse/RAD-643 is released.