Add support for allow_seen in Recommendation requests #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foglcz
force-pushed
the
feature/allow-seen
branch
from
4b6631a
to
cfd1929
Compare
VincTheSecond
previously approved these changes
Sep 14, 2018
OndraM
requested changes
Sep 17, 2018
| /** | ||
| * Allow items, that the user has already "seen" | ||
| * | ||
| * By default user won't see any items, that he or she has visitted (and we have recorded DetailView interaction.) |
| * If you want to circumvent this, and get recommendations including the ones, that the user has already visitted, | ||
| * you can set the "seen" allowance here. | ||
| */ | ||
| public function setAllowSeen(bool $seen = true): self |
There was a problem hiding this comment.
This is confusing - we should either has setter setAllowSeen(bool) with required parameter, or two methods to set it to true and false (allowSeen() and eg. disallowSeen()). For simplicity I'd go for the first variant, but for sure not mix those two approaches.
| @@ -242,6 +258,10 @@ protected function getCommandParameters(): array | |||
| $parameters['model_name'] = $this->modelName; | |||
| } | |||
|
|
|||
| if ($this->allowSeen) { | |||
There was a problem hiding this comment.
Rather strict comparison (eg. !== false) instead of this truthy condition.
foglcz
force-pushed
the
feature/allow-seen
branch
from
cfd1929
to
5d8b09f
Compare
OndraM
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
>= 7.46.0By default, "seen" is any item, that the user has DetailView'ed. This however, can be changed for any given model, so "seen" can mean different things in
defaultandgammamodel for any particular client.