Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new item property type geolocation #89

Merged
merged 2 commits into from Oct 1, 2018
Merged

Conversation

jirinovak
Copy link
Member

Type Feature
Fixes issues RAD-1822
Requires Matej >= 7.47.0
Documentation updated
BC Break No
Tests updated yes
Notes n/a

New item property type geolocation is required for using new operator near https://admin.matej.lmc.cz/docs/query_language.html#geolocation.

This item property is composite type. So question is if we should validate it's value?

@ghost
Copy link

ghost commented Sep 27, 2018

Fails
🚫

There are some fixup/squash commits that needs to be applied before merge.

🚫

Backward incompatible changes detected

Backward incompatible changes introduced by this PR

  • [BC] Value of constant Lmc\Matej\Matej::VERSION changed from '2.0.0' to '2.1.1'

Generated by 🚫 dangerJS

Copy link
Member

@OndraM OndraM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the validation - the PHP client hasn't knowledge about data structure each user has in Matej. Thus when you setup item property as set, timestamp, geolocation etc., when updating its content, there is no way how to know against which Matej internal type the value should be validated.

So you must build the request to match the internal type of the property you setup in Matej, the client cannot do the validation for you.

$matej->request()
    ->events()
    ->addItemProperty(
        ItemProperty::create('item-id', ['my_geolocation_field_but_client_do_not_know_the_type' => ['it', 'is', 'your' 'responsibility', 'to', 'provide', 'valid', 'data']])
    )
...

CHANGELOG.md Outdated
@@ -5,6 +5,8 @@
<!-- There is always Unreleased section on the top. Subsections (Added, Changed, Fixed, Removed) should be added as needed. -->

## Unreleased
### Added
- New item property type `geolocation`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ass dot at the end of line

@OndraM OndraM merged commit 8dc62ef into master Oct 1, 2018
@OndraM
Copy link
Member

OndraM commented Oct 1, 2018

Thanks @jirinovak 🎉

@OndraM OndraM deleted the feature/add-geolocation branch March 31, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants