Drop PHP 7.2 support to upgrade PHPUnit #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndraM
force-pushed
the
feature/phpunit-upgrade
branch
from
c42c92b
to
60d8f68
Compare
OndraM
requested review from
dudla,
florianjiri,
hokypierce,
janicekt,
jirinovak,
kdosiodjinud,
legendik,
MarketaSebkova and
obelixicek
legendik
approved these changes
Nov 27, 2020
hokypierce
reviewed
Nov 27, 2020
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| ## Unreleased | |||
| - Replace `Symplify\CodingStandard\Sniffs\Naming\[AbstractClassNameSniff, ClassNameSuffixByParentSniff, InterfaceNameSniff and TraitNameSniff]` with equivalent versions backported to this repository. | |||
| - Drop PHP 7.2 support. | |||
There was a problem hiding this comment.
Dependency change is not BC break (library public API was not changed). See https://sebastiandedeyne.com/composer-semver-and-underlying-dependency-changes/
Do I need to increment my package’s major version when I update the language requirement?
No. (...)
However, this whole will be part of php-coding-standard 3.0, so it will effectively be in next major release.
jirinovak
approved these changes
Dec 1, 2020
kdosiodjinud
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.