Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Remove ecs-8.x.php files to simplify configuration #96

Merged
merged 1 commit into from
May 13, 2024

Conversation

OndraM
Copy link
Member

@OndraM OndraM commented May 9, 2024

I tend to believe we no longer need these files with extra config for specific PHP version:

  • There aren't any check in them
  • Fixers which depends on some PHP version (eg. they require PHP 8.1 features) have version detection build inside them and they don't run if they detect unsupported PHP version
  • In case we would need such feature to make PHP version dependent config, we can do it directly in the ecs.php file (if (PHP_VERSION >= xxx) { ... })

So because of the near-to-zero value and to make the configuration simpler I suggest removing these extra files.

@OndraM OndraM merged commit 8e9163c into main May 13, 2024
24 checks passed
@OndraM OndraM deleted the feature/extra-configs branch May 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants