Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(ci): Test builds also on Node.js v20 #1251

Merged
merged 1 commit into from Jan 23, 2024
Merged

Conversation

literat
Copy link
Collaborator

@literat literat commented Jan 23, 2024

Description

Test builds also on Node.js v20.

Additional context

Issue reference

https://jira.lmc.cz/browse/DS-809


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@literat literat requested a review from a team as a code owner January 23, 2024 13:04
Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 95b878f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65afb942ad62b10008248bc4

@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Jan 23, 2024
Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 95b878f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65afb94270d55d00084e84b3

Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 95b878f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65afb942d8ee6c000833c296

Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 95b878f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65afb942d8ee6c000833c298

Copy link
Contributor

Coverage Status

coverage: 71.623% (-8.7%) from 80.368%
when pulling 95b878f on chore/build-on-node-v20
into 654a147 on main.

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without any doubts, this is the right direction. But please let's get rid of v16 as soon as possible so the build doesn't take more time than we really need. 🚀

@literat
Copy link
Collaborator Author

literat commented Jan 23, 2024

Without any doubts, this is the right direction. But please let's get rid of v16 as soon as possible so the build doesn't take more time than we really need. 🚀

That moment is near. We should make this change right after we release v2, e.g. release v3 right after that.

@literat literat merged commit ab690df into main Jan 23, 2024
21 checks passed
@literat literat deleted the chore/build-on-node-v20 branch January 23, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants