Feat(web-twig): Introduce option to disable scrolling inside Modal #D… #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
adamkudrna,
pavelklibani and
a team
as code owners
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-react canceled.
|
pavelklibani
approved these changes
Feb 6, 2024
packages/web-twig/src/Resources/components/Modal/Modal.stories.twig
Outdated
Show resolved
Hide resolved
packages/web-twig/src/Resources/components/Modal/stories/ModalUniformModalOnMobile.twig
Outdated
Show resolved
Hide resolved
literat
reviewed
Feb 6, 2024
literat
approved these changes
Feb 6, 2024
…S-732 Scrolling inside `ModalDialog` can now be turned off by setting the `isScrollable` prop to false.
crishpeen
force-pushed
the
feature/web-twig-modal-scrolling
branch
from
37ed8c1
to
65ce4c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…S-732
Scrolling inside
ModalDialogcan now be turned off by setting theisScrollableprop to false.Description
Additional context
Issue reference
Before submitting the PR, please make sure you do the following
fixes #123).