Stack no longer requires the hasSpacing prop to apply custom spacing #DS-1133
#1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pply custom `spacing` #DS-1133 For custom spacing, using the `spacing` prop alone is just fine. The `hasSpacing` prop is still available to quickly apply default spacing.
…apply custom `spacing` #DS-1133 For custom spacing, using the `spacing` prop alone is just fine. The `hasSpacing` prop is still available to quickly apply default spacing.
adamkudrna
requested review from
literat,
crishpeen,
pavelklibani and
a team
as code owners
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamkudrna
changed the title
no longer requires the hasSpacing prop to apply custom spacing` #DS-1133Stack no longer requires the hasSpacing prop to apply custom spacing #DS-1133
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
approved these changes
Feb 29, 2024
pavelklibani
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For custom spacing, using the
spacingprop alone is just fine.The
hasSpacingprop is still available to quickly apply default spacing.Issue reference
https://jira.almacareer.tech/browse/DS-1133