React ModalDialog isExpandedOnMobile default value deprecation #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
adamkudrna,
pavelklibani and
a team
as code owners
✅ Deploy Preview for spirit-design-system-react canceled.
|
✅ Deploy Preview for spirit-design-system-demo canceled.
|
literat
reviewed
Mar 7, 2024
...odemods/src/transforms/v2/web-react/__testfixtures__/modal-isexpandedonmobile-prop.input.tsx
Show resolved
Hide resolved
literat
reviewed
Mar 7, 2024
...demods/src/transforms/v2/web-react/__testfixtures__/modal-isexpandedonmobile-prop.output.tsx
Outdated
Show resolved
Hide resolved
literat
reviewed
Mar 7, 2024
literat
reviewed
Mar 7, 2024
packages/codemods/src/transforms/v2/web-react/modal-isexpandedonmobile-prop.ts
Outdated
Show resolved
Hide resolved
crishpeen
force-pushed
the
feat/react-modaldialog-expanded-default
branch
from
2665cfb
to
68f9223
Compare
pavelklibani
approved these changes
Mar 12, 2024
|
It is possible to add some notice about the existing codemod? To the deprecation itself in the readme or to the deprecations list, e.g.: You can run |
literat
force-pushed
the
feature/react-deprecations
branch
from
b7c6a93
to
9de72ec
Compare
literat
force-pushed
the
feat/react-modaldialog-expanded-default
branch
from
68f9223
to
c8f658d
Compare
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
…f ModalDialog #DS-1146
…eady set #DS-1146
* making it DRY
literat
force-pushed
the
feat/react-modaldialog-expanded-default
branch
from
a554ce7
to
62aa6e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference