BREAKING CHANGE: Remove feature flag for the uniform Modal variant #DS-1181
#1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
requested review from
literat,
crishpeen,
pavelklibani and
a team
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
approved these changes
Apr 19, 2024
pavelklibani
approved these changes
Apr 22, 2024
adamkudrna
force-pushed
the
bc/remove-uniform-modal-feature-flag
branch
from
01c3b3c
to
9c36c0d
Compare
crishpeen
approved these changes
Apr 23, 2024
…iant #DS-1181 The uniform appearance of `Modal` is now default. The docked variant can be turned on using the `.ModalDialog--dockOnMobile` modifier.
…` variant #DS-1181 The uniform appearance of `Modal` is now default. The docked variant can be turned on using the `isDockedOnMobile` option.
…l` variant #DS-1181 The uniform appearance of `Modal` is now default. The docked variant can be turned on using the `isDockedOnMobile` option.
crishpeen
force-pushed
the
bc/remove-uniform-modal-feature-flag
branch
from
9c36c0d
to
a27952a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The uniform appearance of
Modalis now default. The docked variant can be turned on using theisDockedOnMobileoption.Additional context
Issue reference
https://jira.almacareer.tech/browse/DS-1181