Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2 #1368

Merged
merged 95 commits into from
Jun 10, 2024
Merged

Release v2 #1368

merged 95 commits into from
Jun 10, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Apr 23, 2024

Description

Preparation of the second major release of the Spirit Design System.

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-1188

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit f7eee42
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6666b5217791180008d67ca3
😎 Deploy Preview https://deploy-preview-1368--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit f7eee42
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6666b521880423000846194a
😎 Deploy Preview https://deploy-preview-1368--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit ba9f8d7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/663160c3f1d9c70008b06dff

@coveralls
Copy link

coveralls commented Apr 23, 2024

Coverage Status

coverage: 78.63% (+3.5%) from 75.176%
when pulling 0c51cb5 on integration/release-v2
into 1f330f9 on main.

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label May 2, 2024
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@literat literat mentioned this pull request May 27, 2024
1 task
@literat literat marked this pull request as ready for review June 6, 2024 13:47
adamkudrna and others added 4 commits June 9, 2024 22:36
…iant #DS-1181

The uniform appearance of `Modal` is now default. The docked variant can be
turned on using the `.ModalDialog--dockOnMobile` modifier.

See the Modal: Uniform Variant section
in the web package Migration Guide to version 2.
…` variant #DS-1181

The uniform appearance of `Modal` is now default. The docked variant can be
turned on using the `isDockedOnMobile` option.

See the Modal: ModalDialog Uniform Appearance section
in the web-twig package Migration Guide to version 3.
…l` variant #DS-1181

The uniform appearance of `Modal` is now default. The docked variant can be
turned on using the `isDockedOnMobile` option.

See the Modal: ModalDialog Uniform Appearance section
in the web-react package Migration Guide to version 2.
…ure flag #DS-1067

See the Dropdown: Shadow section
in the web package Migration Guide to version 2.
literat and others added 25 commits June 10, 2024 10:10
… `ModalDialog` #DS-1134

1. Custom height and custom max height can be set individually on all breakpoints now.
2. The `--modal-preferred-height-mobile` and `--modal-preferred-height-tablet` custom
   properties were renamed.

See the Modal: Custom Height section in the web package Migration Guide to version 2.
…ops and enhance them #DS-1134

See the Modal: ModalDialog Custom Height section
in the web-twig package Migration Guide to version 3.
See the Tooltip: Hidden By Default section
in the web-twig package Migration Guide to version 3.
- removed data-spirit-placement-controlled from TooltipPopover
- changed some texts to match other demos
- removed check in Tooltip plugin for data-spirit-placement-controlled
- fix for dismissible tooltip to not close on clickOutside
- removed selectors from css for data-spirit-placement-controlled
- fix and update demo to match demos in react and twig

See the Tooltip: Floating UI only section in the web package Migration Guide to version 2.
- fix and update demo to match demos in react and web

See the Tooltip: TooltipPopover enableControlledPlacement Prop section
in the web-twig package Migration Guide to version 3.
…rops and enhance them #DS-1134

See the Modal: ModalDialog Custom Height section
in the web-react package Migration Guide to version 2.
… `isAtEnd` modifier #DS-1059

See the Header: HeaderDesktopActions Alignment section
in the web package Migration Guide to version 2.
… in favor of `isAtEnd` #DS-1059

See the Header: HeaderDesktopActions isAtEnd prop section
in the web-twig package Migration Guide to version 3.
…in favor of `isAtEnd` #DS-1059

See the Header: HeaderDesktopActions isAtEnd prop section
in the web-react package Migration Guide to version 2.
- Tooltip web package docs updated
- Tooltip web demo changed to reflect new classnames changes

See the Tooltip: New Structure section
in the web package Migration Guide to version 2.
- TooltipWrapper renamed to Tooltip
- Changed all stories to use the new Tooltip component structure
- Updated README

See the Tooltip: New Structure section
in the web-twig package Migration Guide to version 3.
- changed internal classnames for Tooltip
- updated to new structure using 'screen' function
Copy link
Contributor

@pavelklibani pavelklibani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍌

@literat literat merged commit 9d057fb into main Jun 10, 2024
29 checks passed
@literat literat deleted the integration/release-v2 branch June 10, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants