Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE(web-twig): Remove class and style from abstract Header components #DS-920 #1381

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

crishpeen
Copy link
Member

See the Header: Abstracts Class and Style section in the web-twig package Migration Guide to version 3.

Description

Additional context

Issue reference

…r components #DS-920

See the Header: Abstracts Class and Style section in the web-twig
package Migration Guide to version 3.
@github-actions github-actions bot added the BC Breaking change label Apr 28, 2024
Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit b24b433
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/662e64c3750b5a0008b31c4f
😎 Deploy Preview https://deploy-preview-1381--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Apr 28, 2024

Coverage Status

coverage: 80.657% (-15.7%) from 96.371%
when pulling b24b433 on bc/remove-header-abstract-hatches
into fb78e61 on integration/release-v2.

@crishpeen crishpeen merged commit c91ce54 into integration/release-v2 Apr 30, 2024
25 checks passed
@crishpeen crishpeen deleted the bc/remove-header-abstract-hatches branch April 30, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants