Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE(web): PaginationItem has the same width as the Pagina… #1393

Merged

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented May 2, 2024

…tionButtonLink in Pagination #DS-1030

Description

Additional context

Issue reference

@curdaj curdaj added BC Breaking change run-visual-tests Runs visual regression testing on this PR labels May 2, 2024
Copy link

netlify bot commented May 2, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit d921d99
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66348b65b625c50008934976
😎 Deploy Preview https://deploy-preview-1393--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@curdaj
Copy link
Contributor Author

curdaj commented May 2, 2024

Please check the commit message to ensure that it is correctly worded and understandable😉

@curdaj curdaj force-pushed the bc/ds-1030-change-items-size-in-pagination branch from aa9a519 to df459d2 Compare May 2, 2024 12:51
@curdaj curdaj marked this pull request as ready for review May 2, 2024 12:59
@coveralls
Copy link

coveralls commented May 2, 2024

Coverage Status

coverage: 80.418% (-16.0%) from 96.371%
when pulling d921d99 on bc/ds-1030-change-items-size-in-pagination
into acd6d16 on integration/release-v2.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@curdaj curdaj force-pushed the bc/ds-1030-change-items-size-in-pagination branch from df459d2 to 1825988 Compare May 2, 2024 14:19
@crishpeen
Copy link
Member

Please check the commit message to ensure that it is correctly worded and understandable😉

BREAKING CHANGE(web): Item has the same width as the ButtonLink in Pagination #DS-1030

It is good, I can only do nitpicking :) Maybe I would avoid the usage of ButtonLink because, in the web package, there is actually no ButtonLink and in the long term, we plan to deprecate ButtonLink everywhere (which, of course, you couldn't know). But we already have a component called Item, so maybe I would turn the sentence around to something like: Pagination Item has the same minimal width as Button.

But your current version is also understandable and I will leave it up to you :)

@curdaj curdaj force-pushed the bc/ds-1030-change-items-size-in-pagination branch from 1825988 to d921d99 Compare May 3, 2024 06:59
@curdaj curdaj merged commit a3bfba3 into integration/release-v2 May 3, 2024
13 checks passed
@curdaj curdaj deleted the bc/ds-1030-change-items-size-in-pagination branch May 3, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Breaking change run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants