Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE(web-react): TooltipModern modern to Tooltip #1394

Merged
merged 2 commits into from
May 14, 2024
Merged

BREAKING CHANGE(web-react): TooltipModern modern to Tooltip #1394

merged 2 commits into from
May 14, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented May 2, 2024 •
edited

Description

  • TooltipModern renamed to Tooltip
  • old Tooltip removed
  • UncontrolledTooltip updated to use new structure with TooltipTrigger and TooltipPopover
  • added missing props and stories to storybook
  • updated tests
  • deleted old e2e visual test for TooltipModern

TODO:

  • Migration guide
  • Codemod

Additional context

If possible demo sync will be solved in different issue:
https://jira.almacareer.tech/browse/DS-1249

Issue reference

Nahradit Tooltip TooltipModern

@pavelklibani pavelklibani self-assigned this May 2, 2024
@github-actions github-actions bot added the BC Breaking change label May 2, 2024
@netlify Netlify
Copy link

netlify bot commented May 2, 2024 •
edited

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit a466f05
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6642197ef45a2600082d9cf1
😎 Deploy Preview https://deploy-preview-1394--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented May 2, 2024 •
edited

Coverage Status

coverage: 79.967% (-16.4%) from 96.371%
when pulling a466f05 on bc/ds-1191-tooltip
into 80cae41 on integration/release-v2.

@pavelklibani pavelklibani added the run-visual-tests Runs visual regression testing on this PR label May 2, 2024
@pavelklibani pavelklibani marked this pull request as ready for review May 3, 2024 09:57
crishpeen
crishpeen reviewed May 7, 2024
View reviewed changes
packages/web-react/src/components/Tooltip/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Tooltip/__tests__/Tooltip.test.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Tooltip/__tests__/Tooltip.test.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Tooltip/demo/TooltipDefault.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Tooltip/demo/TooltipHover.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Tooltip/demo/TooltipIcon.tsx Show resolved Hide resolved
packages/web-react/src/components/Tooltip/demo/TooltipPlacements.tsx Show resolved Hide resolved
packages/web-react/src/components/Tooltip/stories/UncontrolledTooltip.stories.tsx Outdated Show resolved Hide resolved
tests/e2e/demo-components-compare.spec.ts-snapshots/tooltipmodern-chromium-linux.png Outdated Show resolved Hide resolved
@literat
Copy link
Collaborator

literat commented May 9, 2024

Needs to be rebased.

@pavelklibani
Copy link
Contributor Author

rebase done

@pavelklibani pavelklibani force-pushed the bc/ds-1191-tooltip branch 2 times, most recently from 2da0343 to 5a87e4d Compare May 13, 2024 07:55
crishpeen
crishpeen approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only thing I would add is to prevent outside click close when the tooltip is dismissable, but we can do it in a separate issue. Can you create it, please?

packages/web-react/src/components/Tooltip/useTooltipStyleProps.ts Outdated Show resolved Hide resolved
@pavelklibani
Copy link
Contributor Author

LGTM, the only thing I would add is to prevent outside click close when the tooltip is dismissable, but we can do it in a separate issue. Can you create it, please?

Yes i will create this issue

@pavelklibani
BREAKING CHANGE(web-react): Rename TooltipModern to Tooltip
5784151
@pavelklibani
Fix(web): Change max width for dismissible tooltip
a466f05 
- Changed css value of isDismissible class to
prevent width jumps on mouse hovering
@pavelklibani pavelklibani merged commit aefa9f7 into integration/release-v2 May 14, 2024
13 checks passed
@pavelklibani pavelklibani deleted the bc/ds-1191-tooltip branch May 14, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

@crishpeen crishpeen crishpeen approved these changes

@curdaj curdaj curdaj approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna

Assignees

@pavelklibani pavelklibani

Labels
BC Breaking change run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pavelklibani @coveralls @literat @crishpeen @curdaj