Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Add mandatory id prop for Collapse and Dropdown component #DS-1190 #1402

Merged
merged 2 commits into from
May 14, 2024
Merged

BREAKING CHANGE: Add mandatory id prop for Collapse and Dropdown component #DS-1190 #1402

merged 2 commits into from
May 14, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented May 7, 2024

…ent #DS-1190

Description

Additional context

Issue reference

@github-actions github-actions bot added the BC Breaking change label May 7, 2024
@netlify Netlify
Copy link

netlify bot commented May 7, 2024 •
edited

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 105ec2f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66431f981ad9760008b024c0
😎 Deploy Preview https://deploy-preview-1402--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented May 7, 2024 •
edited

Coverage Status

coverage: 79.9% (-16.5%) from 96.371%
when pulling 105ec2f on bc/ds-1190-mandatory-id-in-dropdown-and-collapse
into c93d91d on integration/release-v2.

@curdaj curdaj force-pushed the bc/ds-1190-mandatory-id-in-dropdown-and-collapse branch 2 times, most recently from ac8bedd to f81df55 Compare May 10, 2024 10:58
@curdaj curdaj marked this pull request as ready for review May 10, 2024 11:49
@curdaj curdaj changed the title BREAKING CHANGE: Add mandatory id prop for Collapse component #DS-1190 BREAKING CHANGE: Add mandatory id prop for Collapse and Dropdown component #DS-1190 May 10, 2024
@curdaj curdaj requested a review from literat May 13, 2024 08:17
literat
literat approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curdaj curdaj force-pushed the bc/ds-1190-mandatory-id-in-dropdown-and-collapse branch from f48eae6 to 105ec2f Compare May 14, 2024 08:23
@curdaj curdaj merged commit cec6ada into integration/release-v2 May 14, 2024
27 checks passed
@curdaj curdaj deleted the bc/ds-1190-mandatory-id-in-dropdown-and-collapse branch May 14, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna

@crishpeen crishpeen Awaiting requested review from crishpeen

Assignees

@curdaj curdaj

Labels
BC Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@curdaj @coveralls @literat @pavelklibani