BREAKING CHANGE: id prop is required for all form components #DS-885 #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
curdaj
changed the title
adamkudrna
reviewed
May 14, 2024
packages/web-react/src/components/FieldGroup/__tests__/FieldGroup.test.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Select/__tests__/Select.test.tsx
Outdated
Show resolved
Hide resolved
curdaj
requested review from
literat,
crishpeen,
pavelklibani and
a team
as code owners
literat
reviewed
May 15, 2024
packages/web-react/src/components/FieldGroup/__tests__/FieldGroup.test.tsx
Outdated
Show resolved
Hide resolved
literat
reviewed
May 15, 2024
packages/web-react/src/components/TextArea/__tests__/TextArea.test.tsx
Outdated
Show resolved
Hide resolved
literat
reviewed
May 15, 2024
|
It is looking good for me. I have only two suggestions for a little refactor to keep things a little bit DRY :-) |
literat
reviewed
May 16, 2024
literat
reviewed
May 16, 2024
literat
reviewed
May 16, 2024
literat
reviewed
May 16, 2024
literat
approved these changes
May 17, 2024
literat
force-pushed
the
integration/release-v2
branch
from
506f268
to
52cad76
Compare
|
@curdaj Please, do a rebase :-) |
curdaj
force-pushed
the
bc/ds-885-manadatory-id-for-forms
branch
3 times, most recently
from
bbf7e02
to
90c2451
Compare
curdaj
force-pushed
the
bc/ds-885-manadatory-id-for-forms
branch
from
90c2451
to
c00fd4f
Compare
Done. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🚀
Additional context
Issue reference
https://jira.almacareer.tech/browse/DS-885