Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web, web-twig, web-react) Toast AutoClose #DS-1251 #1415

Merged
merged 3 commits into from
May 23, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented May 16, 2024

Description

Additional context

  • web
  • web-twig
  • web-react
    ...
  • Visual tests

Issue reference

Toast | automatické zavírání Toastu

@pavelklibani pavelklibani self-assigned this May 16, 2024
@github-actions github-actions bot added the feature New feature or request label May 16, 2024
Copy link

netlify bot commented May 16, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit b774c01
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/664dd0868d3f21000890e8f9
😎 Deploy Preview https://deploy-preview-1415--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 16, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit b774c01
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/664dd0869cd8ed0008903912
😎 Deploy Preview https://deploy-preview-1415--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani changed the title Feat/ds 1251 toast autoclose Feat(web, web-twig, web-react) Toast AutoClose #DS-1251 May 16, 2024
@pavelklibani pavelklibani changed the base branch from main to integration/toast-queue May 16, 2024 09:55
@coveralls
Copy link

coveralls commented May 16, 2024

Coverage Status

Changes unknown
when pulling b774c01 on feat/ds-1251-toast-autoclose
into ** on main**.

Base automatically changed from integration/toast-queue to main May 16, 2024 11:51
@pavelklibani pavelklibani force-pushed the feat/ds-1251-toast-autoclose branch 2 times, most recently from ea26dcf to add117e Compare May 16, 2024 14:07
apps/web-twig-demo/assets/scripts/toast-dynamic.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/withAutoClose.ts Outdated Show resolved Hide resolved
packages/web/src/js/constants.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/Toast/constants.ts Outdated Show resolved Hide resolved
@pavelklibani pavelklibani marked this pull request as ready for review May 18, 2024 15:10
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pavelklibani pavelklibani merged commit 17a54b1 into main May 23, 2024
31 checks passed
@pavelklibani pavelklibani deleted the feat/ds-1251-toast-autoclose branch May 23, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants